Skip to content

Documentation tweaks#7

Merged
garyb merged 1 commit into
purescript:masterfrom
paldepind:minor-documentation-tweaks
Sep 2, 2018
Merged

Documentation tweaks#7
garyb merged 1 commit into
purescript:masterfrom
paldepind:minor-documentation-tweaks

Conversation

@paldepind

Copy link
Copy Markdown
Contributor

This PR makes three small changes to the documentation:

  • Changes an instance of "curried" that should be "uncurried"
  • Removes an outdated reference to rows in the Effect type
  • Changes some wordings slightly to avoid past tense sentences that IMHO feels a bit "historical". For instance "traditionally, it has been difficult [...]" and "there has been no way of giving such functions types". This module is many years old 😉

I hope you like these changes 😄

@hdgarrood

Copy link
Copy Markdown
Contributor

This looks good to me, although I think the ‘it makes it possible...’ construction is a bit unclear, since the word ‘it’ is used to refer to two different things in quick succession, do you think you can find a way to reword that to get rid of one of them?

@paldepind paldepind force-pushed the minor-documentation-tweaks branch from 18726f4 to 17f2112 Compare August 3, 2018 10:13
@paldepind

Copy link
Copy Markdown
Contributor Author

Good point @hdgarrood. I've changed the first "it" to a "this". To me that seems to remove the awkwardness.

@garyb

garyb commented Sep 2, 2018

Copy link
Copy Markdown
Member

Thanks!

@garyb garyb merged commit 4ffec51 into purescript:master Sep 2, 2018
@paldepind paldepind deleted the minor-documentation-tweaks branch September 5, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants