Skip to content

Remove invalid entries from cache-db #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EMattfolk wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Remove invalid entries from cache-db #4407

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6cf6b85
Remove missing files from cache-db
EMattfolk Oct 20, 2022
615b2ba
Remove duplicate source files from cache-db.json
EMattfolk Oct 26, 2022
89c1ced
Refactor
EMattfolk Oct 26, 2022
c621cc0
Add tests
EMattfolk Nov 18, 2022
c653de9
Add change log file
EMattfolk Nov 18, 2022
2ad7cd7
Refactor cache test code
EMattfolk Jan 28, 2023
a883104
Simplify cache pruning implementation
EMattfolk Jan 28, 2023
a307b1e
Merge remote-tracking branch 'upstream/master' into prune-cache-db
EMattfolk Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor cache test code
  • Loading branch information
@EMattfolk
EMattfolk committed Jan 28, 2023
commit 2ad7cd7760bedd7c34a564e227a49f65a1952d1a
35 changes: 7 additions & 28 deletions tests/TestMake.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,71 +204,50 @@ spec = do
writeFileWithTimestamp modulePath timestampA "module Module where\nfoo = 0\n"
compile [modulePath] `shouldReturn` moduleNames ["Module"]

cache <- readCacheDb
if M.keysSet cache == moduleNames ["Module"]
then return ()
else fail "Module not in cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames ["Module"]

it "removes old entry from cache when module is renamed" $ do
let modulePath = sourcesDir </> "Module.purs"

writeFileWithTimestamp modulePath timestampA "module Module where\nfoo = 0\n"
compile [modulePath] `shouldReturn` moduleNames ["Module"]

cache1 <- readCacheDb
if M.keysSet cache1 == moduleNames ["Module"]
then return ()
else fail "Module not in cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames ["Module"]

writeFileWithTimestamp modulePath timestampA "module Module2 where\nfoo = 0\n"
compile [modulePath] `shouldReturn` moduleNames ["Module2"]

cache2 <- readCacheDb
if M.keysSet cache2 == moduleNames ["Module2"]
then return ()
else fail "Module2 not in cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames ["Module2"]

it "removes old entry from cache when file and module is renamed" $ do
let modulePath1 = sourcesDir </> "Module1.purs"

writeFileWithTimestamp modulePath1 timestampA "module Module1 where\nfoo = 0\n"
compile [modulePath1] `shouldReturn` moduleNames ["Module1"]

cache1 <- readCacheDb
if M.keysSet cache1 == moduleNames ["Module1"]
then return ()
else fail "Module1 not in cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames ["Module1"]

removeFile modulePath1
let modulePath2 = sourcesDir </> "Module2.purs"

writeFileWithTimestamp modulePath2 timestampA "module Module2 where\nfoo = 0\n"
compile [modulePath2] `shouldReturn` moduleNames ["Module2"]

cache2 <- readCacheDb
if M.keysSet cache2 == moduleNames ["Module2"]
then return ()
else fail "Module2 not in cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames ["Module2"]

it "removes old entry from cache when file is deleted" $ do
let modulePath = sourcesDir </> "Module.purs"

writeFileWithTimestamp modulePath timestampA "module Module where\nfoo = 0\n"
compile [modulePath] `shouldReturn` moduleNames ["Module"]

cache1 <- readCacheDb
if M.keysSet cache1 == moduleNames ["Module"]
then return ()
else fail "Module not in cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames ["Module"]

removeFile modulePath

compile [] `shouldReturn` moduleNames []

cache2 <- readCacheDb
if M.null cache2
then return ()
else fail "Modules were not removed from cacheDb"
M.keysSet <$> readCacheDb `shouldReturn` moduleNames []

-- Note [Sleeping to avoid flaky tests]
--
Expand Down