remove explicit disabling of Nix in stack.yaml#4198
Conversation
|
I didn't add a Changelog entry (since I guess it is unlikely this will negatively affect anyone), but I could if necessary. |
|
Just to clarify, the issue here is that you have to currently run |
@JordanMartinez Yes. On NixOS, you currently have to run This shouldn't affect building PureScript on other Linux distros. |
|
I don't use |
|
The Windows build failed, so I restarted CI. |
|
@cdepillabout Please add a changelog entry for this, following the instructions listed in |
64e2cb7 to
8f2325b
Compare
|
@JordanMartinez Thanks, I just rebased and pushed a CHANGELOG entry. |
Description of the change
The current
stack.yamlin this repo explicitly disables using Nix for building.In my experience, it is better to just remove the
nix.enable: falseline fromstack.yaml, rather than explicitly disabling it.With
stack, Nix is "required" for building on NixOS. If you explicitly disable Nix support instack.yaml, you won't be able to build on NixOS without usingstack build --nix. It is a little annoying to have to remember to always pass--nix(even though this should basically be the default on NixOS).For all other distros,
stackdefaults to not using Nix, so removingnix.enable: falseshouldn't change anything.The only people who may be negatively affected by this change are people who are running a non-NixOS Linux distro and have
nix.enable: falsein their~/.stack/config.yamland also rely onstackbuilding PureScript without using Nix. I imagine this group of people is either small or non-existent.Checklist: