Skip to content

Do not update externs/cache-db when codgenTargets is empty #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wclr wants to merge 3 commits into
base: master
Choose a base branch
from
+65 −22
Open

Do not update externs/cache-db when codgenTargets is empty #4178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff4e177
Do not modify externs/cache-db when codgenTargets is empty
wclr Aug 26, 2021
6d93fff
Add handling of source file text data instead of file path
wclr Sep 4, 2021
cebed8f
Add ffi check for ide rebuild without codegen
wclr Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not modify externs/cache-db when codgenTargets is empty
  • Loading branch information
@wclr
wclr committed Jul 4, 2022
commit ff4e17739c61b3636a31189f955afb6f5b28c4bb
3 changes: 2 additions & 1 deletion src/Language/PureScript/Ide/Rebuild.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ rebuildFile file actualFile codegenTargets runOpenBuild = do
(result, warnings) <- logPerf (labelTimespec "Rebuilding Module") $
liftIO $ P.runMake (P.defaultOptions { P.optionsCodegenTargets = codegenTargets }) do
newExterns <- P.rebuildModule (shushProgress makeEnv) externs m
updateCacheDb codegenTargets outputDirectory file actualFile moduleName
unless (S.null codegenTargets)
$ updateCacheDb codegenTargets outputDirectory file actualFile moduleName
pure newExterns
case result of
Left errors ->
Expand Down
5 changes: 3 additions & 2 deletions src/Language/PureScript/Make/Actions.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,10 @@ buildMakeActions outputDir filePathMap foreigns usePrefix =

codegen :: CF.Module CF.Ann -> Docs.Module -> ExternsFile -> SupplyT Make ()
codegen m docs exts = do
let mn = CF.moduleName m
lift $ writeCborFile (outputFilename mn externsFileName) exts
let mn = CF.moduleName m
codegenTargets <- lift $ asks optionsCodegenTargets
unless (S.null codegenTargets)
$ lift $ writeCborFile (outputFilename mn externsFileName) exts
when (S.member CoreFn codegenTargets) $ do
let coreFnFile = targetFilename mn CoreFn
json = CFJ.moduleToJSON Paths.version m
Expand Down