Skip to content

Add support for bundling function declarations #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomashoneyman merged 5 commits into from
Jul 20, 2021
Merged

Add support for bundling function declarations #4044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
198f335
Add support for bundling function declarations
kl0tl Apr 4, 2021
4b43185
Update CHANGELOG.md
kl0tl Apr 4, 2021
f928184
fixup! Update CHANGELOG.md
kl0tl Jun 30, 2021
a5673e4
Merge remote-tracking branch 'upstream/master' into add-support-for-b…
kl0tl Jul 20, 2021
9b35823
Add changelog entry
kl0tl Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.d/fix_bundle-function-declarations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Do not remove bindings referenced in function declarations when bundling
4 changes: 4 additions & 0 deletions src/Language/PureScript/Bundle.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,10 @@ matchMember stmt
, JSIdentifier _ name <- var
, JSVarInit _ decl <- varInit
= Just (Internal, name, decl)
-- function foo(...args) { body }
| JSFunction a0 jsIdent a1 args a2 body _ <- stmt
, JSIdentName _ name <- jsIdent
= pure (Internal, name, JSFunctionExpression a0 jsIdent a1 args a2 body)
-- exports.foo = expr; exports["foo"] = expr;
| JSAssignStatement e (JSAssign _) decl _ <- stmt
, Just name <- exportsAccessor e
Expand Down
19 changes: 19 additions & 0 deletions tests/purs/bundle/FunctionDeclaration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
"use strict";

var foo = 0;

function bar(foo) {
return foo;
}

var baz = "Done";

function qux() {
return bar(baz);
}

exports.qux = qux;

var fs = require('fs');
var source = fs.readFileSync(__filename, 'utf-8');
exports.fooIsEliminated = !/^ *var foo/m.test(source);
14 changes: 14 additions & 0 deletions tests/purs/bundle/FunctionDeclaration.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
module Main (main) where

import Prelude
import Effect (Effect)
import Effect.Console (log)
import Test.Assert (assert')

main :: Effect Unit
main = do
assert' "foo" fooIsEliminated
qux >>= log

foreign import qux :: Effect String
foreign import fooIsEliminated :: Boolean