Skip to content

Suggest import for name causing a UnknownName error #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csicar wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Suggest import for name causing a UnknownName error #3716

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb5aa2c
Suggest import for name causing a UnknownName error
csicar Aug 16, 2019
a9eeb77
move suggestion to SimpleError instead of Hint
csicar Aug 18, 2019
1fec741
use wildcard for unused variable
csicar Aug 20, 2019
be52fb9
`errorSuggestion` allows for multiple suggestions
csicar Aug 20, 2019
d94ae1c
rename showSuggestion and errorSuggestion to plural
csicar Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use wildcard for unused variable
  • Loading branch information
@csicar
csicar committed Aug 20, 2019
commit 1fec7418bba0a093ea8a620fb10b1b5cf7811596
2 changes: 1 addition & 1 deletion src/Language/PureScript/Errors.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ errorSuggestion err =
HidingImport mn refs -> suggest $ importSuggestion mn refs Nothing
MissingTypeDeclaration ident ty -> suggest $ showIdent ident <> " :: " <> T.pack (prettyPrintSuggestedType ty)
WildcardInferredType ty _ -> suggest $ T.pack (prettyPrintSuggestedType ty)
UnknownName alternatives unknownName -> suggest $ T.unlines $ (\(mn, ref) -> importSuggestion mn [ref] Nothing) <$> alternatives
UnknownName alternatives _ -> suggest $ T.unlines $ (\(mn, ref) -> importSuggestion mn [ref] Nothing) <$> alternatives
_ -> Nothing
where
emptySuggestion = Just $ ErrorSuggestion ""
Expand Down