Set --haddock flag based on BUILD_TYPE per joneshf#3409
Conversation
|
I guess this still overruns though... |
|
@justinwoo Try rebasing on master now. I had successful CI runs against GHC 8.4.3 |
eaf437a to
34a8651
Compare
|
This may not have been clear, but the script is actually working as intended. We expect to see failures like in https://travis-ci.org/purescript/purescript/builds/413820789 occasionally.
We have enough dependencies that installing them all is likely to take almost all of this time window up, leaving insufficient time to actually run the tests. We therefore rely on the build cache containing the (compiled) dependencies so that we can run the tests during CI and not have to worry about it timing out. As we have seen, installing all the dependencies and then running the tests can take more than 50 minutes on Travis. Therefore, when this does happen, we need to store the progress which has been made installing dependencies so that we can ask Travis to start a new job (by pushing a new commit), and have the new job pick up where the previous one left off. However, since build caches are not stored on errored builds, we need to intervene to ensure that builds which are taking too long get marked as failed instead. This is why we have this part in the build script: Lines 6 to 23 in e184fca The In the case that this happens, all you need to do is push an empty commit to ensure that Travis picks up where it left off. Also, you need to push a new commit instead of amending a previous one: Travis looks at the commit parent to decide which cache to use, so if you instead amend the previous commit and push it again, the cache will be in the same state as in was at the beginning of the previous attempt, which means that the progress made in the previous attempt is lost. Does that make sense? |
|
I previously set a timeout of 45 minutes (see line 8 in the above code snippet), thinking that the remaining 5 minutes would be sufficient to complete the rest of the CI job. The fact that these jobs (eg https://travis-ci.org/purescript/purescript/jobs/413970257) are erroring shows that this is no longer the case, so we need to decrease this timeout. Pursuit's is currently set to 40 minutes; that's probably appropriate here too. |
|
Okay, let's try that |
873cdda to
d0b3bf2
Compare
|
Okay, it built on a shorter timer this time |
* Set --haddock flag based on BUILD_TYPE per joneshf * set lower timeout
Based on #3389 (comment)
Minor change, but if this gets things going, can we unblock other PRs?