Improve parse error messages for .purs-repl#3249
Merged
Merged
Conversation
- Set the file name in error message - Parse whole file at once so correct lines numbers are given in errors - Don't fail on empty lines, whitespace, etc This fixes #3248
Member
|
Can we write a test for this? Just to make sure it doesn't regress. |
Contributor
Author
|
Would it suffice to test |
kritzcreek
approved these changes
Apr 22, 2018
kritzcreek
left a comment
Member
There was a problem hiding this comment.
I tested this and it works great, Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3248
To ensure line numbers are given on errors, I made a new parser that only parses
importstatements, instead of parsing all kinds of commands and rejecting them after the line numbers are forgotten.Since the whole file is parsed all at once, it no longer makes sense to interleave printing, parsing, and executing line-by-line. So I've printed the whole contents verbatim before executing all the imports (assuming the file parsed).
Example: