Fix :browse Prim in REPL, it has no ExternsFile#3246
Merged
Conversation
Member
|
Seems good to me 👍 I'm not too familiar with the REPL code though, so anyone else want to comment? |
kritzcreek
requested changes
Mar 22, 2018
| qualMod = fromMaybe needle (lookupUnQualifiedModName needle imports) | ||
| primMod = P.ModuleName [P.ProperName "Prim"] | ||
| modules = S.fromList (primMod : (P.getModuleName . fst <$> externs)) | ||
| in if qualMod `S.member` modules |
Member
There was a problem hiding this comment.
Something seems weird with the let ... in indentation here. I think the in should be one space to the left?
Contributor
Author
There was a problem hiding this comment.
Sure! I looked for other examples of multi-line let ... in .... I only found one or two, so I have emulated those. If that's not what you intended, I have no problem changing it.
LiamGoodacre
approved these changes
Apr 14, 2018
kritzcreek
approved these changes
Apr 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason
:browse Primfailed is that there's not an entry inpsciLoadedExternsforPrim. This fixes #2672