Skip to content

correctly quote uppercased field labels#3148

Merged
paf31 merged 1 commit into
purescript:masterfrom
Thimoteus:fix-capitalized-labels
Nov 15, 2017
Merged

correctly quote uppercased field labels#3148
paf31 merged 1 commit into
purescript:masterfrom
Thimoteus:fix-capitalized-labels

Conversation

@Thimoteus

@Thimoteus Thimoteus commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

Example:

Source:

module Main where

x :: _
x = {"Test": 3}

Current master:

Warning found:
in module Main
at Main.purs line 3, column 6 - line 3, column 7

  Wildcard type definition has the inferred type
                 
    { Test :: Int
    }            
                 

in value declaration x

With this PR:

Warning found:
in module Main
at Main.purs line 3, column 6 - line 3, column 7

  Wildcard type definition has the inferred type
                   
    { "Test" :: Int
    }              
                   

in value declaration x

garyb
garyb approved these changes Nov 12, 2017
View reviewed changes

@garyb garyb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at least! 👍

@garyb

garyb commented Nov 12, 2017

Copy link
Copy Markdown
Member

Oh, could you add yourself to the CONTRIBUTORS file please?

@Thimoteus Thimoteus force-pushed the fix-capitalized-labels branch from 817bfcd to a19794f Compare November 13, 2017 20:59
@Thimoteus

Thimoteus commented Nov 13, 2017

Copy link
Copy Markdown
Contributor Author

@garyb done!

@hdgarrood

hdgarrood commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

Could you explain what is incorrect about the current behaviour? I don’t understand what the problem is.

@paf31

paf31 commented Nov 14, 2017

Copy link
Copy Markdown
Contributor

@hdgarrood I think the issue is that what is printed now is not actually a syntactically valid type.

@paf31 paf31 merged commit 15d7330 into purescript:master Nov 15, 2017
kritzcreek added a commit to kritzcreek/purescript that referenced this pull request Nov 21, 2017
@kritzcreek
Cherrypick purescript#3148
5253891
kritzcreek added a commit that referenced this pull request Nov 25, 2017
@kritzcreek
Update 0.12 from master (#3159)
eb6e3f3 
* correctly quote uppercased field labels which would otherwise remain unquoted (#3148)

* Update Glob library, fixes #3055 (#3156)

* Update Glob library, fixes #3055

Also update the Stackage snapshot so that we get the latest version of
Glob, which includes memory usage and performance fixes.

* Reduce timeout threshold to help avoid CI failures

* Empty commit to fix Travis
jutaro pushed a commit to mgmeier/purescript that referenced this pull request Mar 12, 2018
@Thimoteus @jutaro
correctly quote uppercased field labels which would otherwise remain …
19a28f8 
…unquoted (purescript#3148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garyb garyb garyb approved these changes

@kritzcreek kritzcreek kritzcreek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thimoteus @garyb @hdgarrood @paf31 @kritzcreek