Skip to content

pretty print proxy types when rendering docs#3144

Merged
LiamGoodacre merged 3 commits into
purescript:0.12.0-devfrom
sloosch:pretty-print-proxy
Nov 19, 2017
Merged

pretty print proxy types when rendering docs#3144
LiamGoodacre merged 3 commits into
purescript:0.12.0-devfrom
sloosch:pretty-print-proxy

Conversation

@sloosch

@sloosch sloosch commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

Fixes #3135 .

@LiamGoodacre

Copy link
Copy Markdown
Member

@sloosch, could you please reopen this against the 0.12.0-dev branch?

@sloosch sloosch changed the base branch from master to 0.12.0-dev November 10, 2017 20:07
@LiamGoodacre

Copy link
Copy Markdown
Member

Thanks. Could you add a test? You'll need to add a file to examples/docs/src and update tests/TestDocs.hs to reference it.

@sloosch

sloosch commented Nov 16, 2017

Copy link
Copy Markdown
Contributor Author

Done!

@LiamGoodacre

Copy link
Copy Markdown
Member

Oh I nearly forgot: could you add yourself to CONTRIBUTORS.md? Then I'll get this merged.
Thanks for working on this.

@LiamGoodacre LiamGoodacre merged commit 14227c7 into purescript:0.12.0-dev Nov 19, 2017
hdgarrood added a commit that referenced this pull request Dec 30, 2017
@hdgarrood hdgarrood mentioned this pull request Dec 30, 2017
hdgarrood added a commit that referenced this pull request Jan 3, 2018
* Revert "pretty print proxy types when rendering docs (#3144)"

This reverts commit 14227c7.

* Revert "Print proxy type as an operator (#3124)"

This reverts commit cfd1db3.

* Revert "Fix proxies: synonyms, inference, traversals, instances (#3095)"

This reverts commit fe0aa0d.

* Revert "Add proxies (#2846)"

This reverts commit 74bc4a9.

* Remove one last occurrence of the ProxyType constructor

* Update tests to not use new proxies
matthewleon pushed a commit to matthewleon/purescript that referenced this pull request Jan 6, 2018
* Revert "pretty print proxy types when rendering docs (purescript#3144)"

This reverts commit 14227c7.

* Revert "Print proxy type as an operator (purescript#3124)"

This reverts commit cfd1db3.

* Revert "Fix proxies: synonyms, inference, traversals, instances (purescript#3095)"

This reverts commit fe0aa0d.

* Revert "Add proxies (purescript#2846)"

This reverts commit 74bc4a9.

* Remove one last occurrence of the ProxyType constructor

* Update tests to not use new proxies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants