Add a bunch of NFData instances#2817
Merged
Merged
Conversation
I also added derived Generic instances in order to be able to define the NFData instances without having to write the necessary code by hand; I expect I'll do it incorrectly if I try to do it by hand. I am mainly doing this because I want to use it to help diagnose bugs like #2772 but I also think it might come in handy in real code at some point too; e.g. if we ever want to store these types in Pursuit's database.
paf31
approved these changes
Apr 8, 2017
paf31
left a comment
Contributor
There was a problem hiding this comment.
LGTM. FYI, you can add NFData to the deriving clause if you use -XDeriveAnyClass.
Contributor
Author
|
Thanks! I opted to do it this way because apparently |
Contributor
|
Oh good point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added derived Generic instances in order to be able to define
the NFData instances without having to write the necessary code by hand;
I expect I'll do it incorrectly if I try to do it by hand.
I am mainly doing this because I want to use it to help diagnose bugs
like #2772 but I also think it might come in handy in real code at some
point too; e.g. if we ever want to store these types in Pursuit's
database.