Strict handling of UTF8 files (fixes fd issue)#2338
Merged
Conversation
Contributor
|
Looks good, thanks! Could you please update |
Member
Isn't it just going to be 0.10? We've not released a non-RC yet... |
Contributor
|
Last time we used 0.9.1 since people had been using the 0.9 release candidate for a while, but I don't mind. |
Contributor
Author
|
Done! |
Contributor
|
I'm not sure why GitHub thinks there is a conflict here. |
Contributor
Author
|
I rebased. =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that on OS X when trying to build the basic purescript-react example I got this error:
This was fixed in #1674 for psc-bundle, but actually my error comes from
pscitself, because it usesreadUTF8Filein various places and the fix was placed only in psc-bundle. Instead, I've fixed the problem at the source by using the already-present utf8-string package to simply decode the strictByteStringinto aString. This is also whathindentdoes.This fixes the issue on my OS X.