Windows CI#2002
Merged
Merged
Conversation
* Add appveyor.yml for windows CI, with automatic release binary bundle publishing * Rework bundle/build-stack script to work on all OSes * Use SHA1 instead of MD5 for the Windows checksum. * Refactor the build-stack script a little * Remove all the other bundle build scripts * Include dependencies in binary bundles (resolves #1952) I haven't managed to get `strip` to work on AppVeyor, but this script has produced an identically sized bundle to the 0.8.4 one (21.3MB) so maybe that's not worth worrying about.
| if [ "$OS" = "win64" ] | ||
| then | ||
| # msys/mingw does not include shasum. :( | ||
| SHASUM="openssl dgst -sha1" |
Member
There was a problem hiding this comment.
Ah cool, I wondered how you'd "fixed" that.
Contributor
|
Looks great! Is Appveyor able to build Mac binaries too? For the secret key, can it be put into an environment variable like in Travis? This way seems like a security issue. |
Contributor
Author
|
No, Appveyor is just Windows. Travis can build Mac binaries, though. The github token here is encrypted, so this ought to be safe (assuming Appveyor doesn't get hacked or anything) but yeah, we can do it like Travis too. |
Contributor
Author
|
I'm going to merge this for now to stop it from making all the other CI builds fail; I think we can always revert this later if it turns out not to work well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishing
I haven't managed to get
stripto work on AppVeyor, but this scripthas produced an identically sized bundle to the 0.8.4 one (21.3MB) so
maybe that's not worth worrying about.
The encrypted github token here is tied to my github account, but it appears I have the permission to edit releases now so that should work fine.