Skip to content

Parse modules in parallel#1593

Merged
paf31 merged 1 commit into
masterfrom
parallel-parse
Nov 2, 2015
Merged

Parse modules in parallel#1593
paf31 merged 1 commit into
masterfrom
parallel-parse

Conversation

@paf31

@paf31 paf31 commented Oct 30, 2015

Copy link
Copy Markdown
Contributor

This reduces the Halogen rebuild time to 0.7s on my machine, with -N7 as the sweet spot.

@phadej

phadej commented Oct 30, 2015

Copy link
Copy Markdown
Contributor

is LICENSE edit intentional?

@paf31

paf31 commented Oct 30, 2015

Copy link
Copy Markdown
Contributor Author

Yes, I added the license file for parallel.

@paf31

paf31 commented Oct 30, 2015

Copy link
Copy Markdown
Contributor Author

But I don't know what happened with the newlines. Glob is a bit of a pain because its license is missing on Hackage, so I have to fix it up manually, and this happens.

@phadej

phadej commented Oct 30, 2015

Copy link
Copy Markdown
Contributor

I'd inspect what happened and try to fix history to look proper. At least in vim it's quite easy to change line-ending back and forth i.e. :set fileformat=unix

@paf31

paf31 commented Oct 30, 2015

Copy link
Copy Markdown
Contributor Author

The line endings were mixed to begin with due to the way the script works.

@paf31

paf31 commented Nov 2, 2015

Copy link
Copy Markdown
Contributor Author

Any other thoughts on this? Shall I merge?

@garyb

garyb commented Nov 2, 2015

Copy link
Copy Markdown
Member

Oh sorry, I missed this one. Cool! 👍

paf31 added a commit that referenced this pull request Nov 2, 2015
@paf31 paf31 merged commit 80fb351 into master Nov 2, 2015
@paf31 paf31 deleted the parallel-parse branch November 2, 2015 18:02
@paf31

paf31 commented Nov 2, 2015

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants