Skip to content

Wrap the in clause of comprehensions across lines if necessary #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cobaltt7 merged 25 commits into from
Sep 8, 2025
Merged

Wrap the in clause of comprehensions across lines if necessary #4699

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
1c2b8d9
CI: Remove now-uneeded workarounds
cobaltt7 May 12, 2025
9b080be
Merge branch 'main' into tech-debt
cobaltt7 May 12, 2025
8285a35
Fix Click typing issue in run self
cobaltt7 May 12, 2025
ac9ca28
Merge branch 'tech-debt' of https://github.com/cobaltt7/black into te…
cobaltt7 May 12, 2025
55f6274
Merge branch 'main' into tech-debt
cobaltt7 May 15, 2025
7755e49
oops, run self
cobaltt7 May 15, 2025
3d02a93
i swear this was failing earlier
cobaltt7 May 15, 2025
7e0e55f
has click updated itself yet on pre-commit.ci
cobaltt7 May 16, 2025
a9f9848
Merge branch 'main' into tech-debt
cobaltt7 May 25, 2025
68732db
Bump click
cobaltt7 May 25, 2025
538ae23
Split the `in` clause of comprehensions onto its own line if necessary
cobaltt7 Jun 20, 2025
82b534e
Merge branch 'main' into gh-3498
cobaltt7 Jun 20, 2025
e107887
Lint issues
cobaltt7 Jun 20, 2025
602ca78
Move to preview style
cobaltt7 Jun 20, 2025
b6cfff1
run self
cobaltt7 Jun 20, 2025
6b84360
Merge branch 'main' into gh-3498
cobaltt7 Jun 28, 2025
511a7f7
Merge branch 'main' into gh-3498
cobaltt7 Jul 3, 2025
388499b
Alternative approach
cobaltt7 Aug 3, 2025
69b2e3a
oops!
cobaltt7 Aug 3, 2025
c6484e4
run test on preview, not unstable
cobaltt7 Aug 3, 2025
27a0cc9
Don't remove parens around ternaries
cobaltt7 Aug 10, 2025
867bd71
Merge branch 'main' into gh-3498
cobaltt7 Sep 7, 2025
f350d71
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 7, 2025
7b2c2ce
Update src/black/linegen.py
cobaltt7 Sep 7, 2025
8feab82
Update docs/the_black_code_style/future_style.md
cobaltt7 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run self 
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
  • Loading branch information
@cobaltt7
cobaltt7 committed Jun 20, 2025
commit b6cfff1f59013c84321eb8635277ada3e944ecbc
5 changes: 3 additions & 2 deletions src/black/linegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ def visit_dictsetmaker(self, node: Node) -> Iterator[Line]:
child,
parent=node,
mode=self.mode,
remove_brackets_around_comma=False )
remove_brackets_around_comma=False,
)
else:
wrap_in_parentheses(node, child, visible=False)
yield from self.visit_default(node)
Expand All @@ -271,7 +272,7 @@ def visit_funcdef(self, node: Node) -> Iterator[Line]:
child,
parent=node,
mode=self.mode,
remove_brackets_around_comma=False
remove_brackets_around_comma=False,
):
wrap_in_parentheses(node, child, visible=False)
else:
Expand Down