Repository navigation
Close mmap files when a MmapedDict is discarded - #1235
Open
Shaisolaris wants to merge 3 commits into
Open
Shaisolaris wants to merge 3 commits into
Shaisolaris wants to merge 3 commits into
Conversation
Dropping the object without close() left the backing file open, so CPython reported an unclosed-file ResourceWarning. Growing the map also replaced the previous mmap without closing it. Close the previous map before a larger map is created, and close both the map and the file from close() and __del__. Signed-off-by: Shai <66793913+Shaisolaris@users.noreply.github.com>
Cover the unclosed-file warning and values written through a map growth. Signed-off-by: Shai <66793913+Shaisolaris@users.noreply.github.com>
Growing the map replaced the previous mmap without closing it. close() now closes the map and the file independently, and __del__ calls close(). Signed-off-by: Shai <66793913+Shaisolaris@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008.
Dropping a MmapedDict without close() left the backing file open. CPython then reports ResourceWarning: unclosed file. Growing the map also replaced the previous mmap without closing it.
close() now closes the map and the file independently, del calls close(), and growth closes the previous map before mapping the larger file.
Tested against a copy of prometheus_client/mmap_dict.py on Python 3.14.7. Before the change, deleting the object after write_value emitted ResourceWarning for the unclosed file. After the change, the same sequence emits no warning, and 40 values written through two growth steps read back correctly.