Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The span regex in
_parse_nh_structonly matched unsigned offsets, so a span list such aspositive_spans:[-2:2]was dropped and the parsedNativeHistogramended up with deltas but no spans. The first span offset is the starting bucket index and is negative for buckets below 1, which is common for histograms in seconds. The client's own OpenMetrics exposition writes such offsets, so its output did not round trip.This allows an optional minus sign on span offsets, matching what the deltas regex already does, and adds a parser test with negative offsets in both positive and negative spans.
@csmarchbanks
Fixes #1232