Repository navigation
Parse escaped quotes in OpenMetrics exemplar label values - #1230
Open
spicysharkco wants to merge 1 commit into
Open
spicysharkco wants to merge 1 commit into
spicysharkco wants to merge 1 commit into
Conversation
The exemplar scanner in _parse_remaining_text flipped its in-quotes state on every double quote, so a label value like x"y, which the writer emits as x\"y, made the whole line fail with "Invalid line". Ignore quotes preceded by an odd number of backslashes. Signed-off-by: spicysharkco <321699413+spicysharkco@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parse_remaining_textinopenmetrics/parser.pyflips its in-quotes state on every", escaped or not. An exemplar label value that contains a quote, whichopenmetrics.exposition.generate_latestwrites as\", never reaches the closing}and the line is rejected, so the parser cannot read the writer's own output:The scan now skips a quote that is preceded by an odd number of backslashes, using the
_is_character_escapedhelper already in the module. The same applies to histogram and gaugehistogram bucket exemplars, which go through the same function.Added
test_exemplar_label_escapingnext totest_label_escaping. It fails on master with the error above and passes with the change; the\\row guards the closing quote after an escaped backslash.tests/openmetricspasses, flake8 and isort are clean. No issue exists for this.@csmarchbanks