process_collector.py assumes /proc/self/fd is readable for process_open_fds #95

Activity

1. hedgepigdaniel commented on Aug 10, 2017

   

   hedgepigdaniel

   on Aug 10, 2017

   More actions

   So annoying, also an issue with Ubuntu 12.04 built in uwsgi init.d service.

   I assume this is a problem whenever uwsgi does its own priviledge deescalation

   https://unix.stackexchange.com/questions/75045/files-in-proc-pid-e-g-ssh-agent-chrome-are-not-owned-by-user-but-by-root

   When used in https://github.com/korfuri/django-prometheus the stacktrace looks like this:

   Traceback (most recent call last):
     File "/usr/lib/python2.7/SocketServer.py", line 284, in _handle_request_noblock
       self.process_request(request, client_address)
     File "/usr/lib/python2.7/SocketServer.py", line 310, in process_request
       self.finish_request(request, client_address)
     File "/usr/lib/python2.7/SocketServer.py", line 323, in finish_request
       self.RequestHandlerClass(request, client_address, self)
     File "/usr/lib/python2.7/SocketServer.py", line 638, in __init__
       self.handle()
     File "/usr/lib/python2.7/BaseHTTPServer.py", line 340, in handle
       self.handle_one_request()
     File "/usr/lib/python2.7/BaseHTTPServer.py", line 328, in handle_one_request
       method()
     File "/home/engine/venv/local/lib/python2.7/site-packages/prometheus_client/exposition.py", line 86, in do_GET
       output = generate_latest(registry)
     File "/home/engine/venv/local/lib/python2.7/site-packages/prometheus_client/exposition.py", line 63, in generate_latest
       for metric in registry.collect():
     File "/home/engine/venv/local/lib/python2.7/site-packages/prometheus_client/core.py", line 97, in collect
       for metric in collector.collect():
     File "/home/engine/venv/local/lib/python2.7/site-packages/prometheus_client/process_collector.py", line 84, in collect
       len(os.listdir(os.path.join(pid, 'fd'))))
   OSError: [Errno 13] Permission denied: '/proc/self/fd'
   
2. hedgepigdaniel commented on Aug 10, 2017

   

   hedgepigdaniel

   on Aug 10, 2017

   More actions

   Thanks @RalphCorderoy for the patch, it fixed the problem for me (I assume at the expense of file handle information) - I committed it here if anyone wants to try it: https://github.com/prometheus/client_python/compare/master...hedgepigdaniel:ignore-fd-permissions?expand=1

   👍React with 👍1Reacted by Ralph Corderoy
3. hedgepigdaniel

   added a commit that references this issue on Sep 14, 2017

   Ignore EACCESS when reading open file handles

   529c8f5
4. blopker

   added a commit that references this issue on Oct 20, 2017

   Fix prometheus#95: catch OSError when collecting file descriptors.

   This issue will close once commit 4fa3e53 is merged into the 'master' branch.

   4fa3e53
5. brian-brazil

   closed this as completedin 6625f89on Oct 20, 2017