Repository navigation
Allow GraphiteBridge to set a prefix #49
Description
Hi,
while testing and maybe transitioning, I’m very grateful for the GraphiteBridge.
However as far as I can tell, there’s no way to namespace (with a dot) my metrics and they just land in the main “directory”.
Could you please add a way to set a prefix that is prepended to all metrics?
Activity
brian-brazil commentedon Oct 2, 2015
That sounds like a reasonable and simple request, I'll add it to the Hacktoberfest list.
kvikas commentedon Oct 3, 2015
Hi Brian,
I was looking into this. Does this mean
bridge.graphite.GraphiteBridge.push()needs an optional namespace parameter? And it gets_sanitize()ed with.preserved and prepended to name.brian-brazil commentedon Oct 3, 2015
I'd add an optional
prefixparameter so as not to confuse it with thenamespaceparameter that Prometheus client libraries have. I'm not sure there's any need to sanitize it, as it's provided by a user that knows that it's going to graphite and what storage backend they have - unlike normal label values which can be arbitrary Unicode.Support for namespace in graphite bridge prometheus#49
Support for namespace in graphite bridge prometheus#49
brian-brazil commentedon Oct 4, 2015
Fixed by #56
hynek commentedon Oct 4, 2015
Sweet, thanks!