Skip to content

Friendly Names for new Sketches#6048

Closed
KartikSoneji wants to merge 3 commits into
processing:masterfrom
KartikSoneji:feature-friendly-names
Closed

Friendly Names for new Sketches#6048
KartikSoneji wants to merge 3 commits into
processing:masterfrom
KartikSoneji:feature-friendly-names

Conversation

@KartikSoneji

@KartikSoneji KartikSoneji commented May 23, 2020

Copy link
Copy Markdown

Please refer to this thread on the Processing forum.

Closes #6045

Adds:
image

@ghost

ghost commented Oct 9, 2020

Copy link
Copy Markdown

Seems like a great feature to me.
You should probably write Closes #6045 instead of Closes issue #6045 to link the issue and pull request.
See also: Issue-linking keywords

@KartikSoneji

Copy link
Copy Markdown
Author

Oh, I thought Closes issue would work the same as Closes.
Thanks for pointing it out! I'll make the changes.
Glad you liked the feature.

@benfry

benfry commented Oct 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @KartikSoneji for this helpful and complete patch. I'd be happy to incorporate this with two changes:

  1. If you'd be willing to move the “friendly words” file to a file named friendly.txt in build/shared/lib, and load that on first use instead of making it a class, i.e. something like:
	if (friendlyWords == null) {
        friendlyWords = PApplet.loadStrings(Base.getLibFile("friendly.txt"));
    }
  1. Make this a PR against the Processing 4 repo where current development is happening.

Thanks again…

@KartikSoneji

Copy link
Copy Markdown
Author

Hi @benfry !

Thanks for reviewing the changes, and I am glad you liked them.
I'll start porting the patch to Processing 4.

Can you please explain the benefits of loading the list of words on first use as opposed to having everything self-contained in one .class file?
I assume it is to decouple the list of words from the program source, but the list is unlikely to change.
On the other hand, loading a file adds additional complexity and one more point of failure (what happens if it cannot be loaded?)

@benfry

benfry commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Implemented for 4.0 beta 9, arriving shortly.

@benfry benfry closed this Aug 3, 2022
@github-actions

github-actions Bot commented Aug 3, 2023

Copy link
Copy Markdown

This pull request has been automatically locked. Pull requests that have been closed are automatically locked 30 days after the last comment.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Friendly names for Processing Sketches like the p5.js web editor

2 participants