[wip] Autoformatter#2560
Closed
GKFX wants to merge 6 commits into
Closed
Conversation
Miscellaneous fixes. I broke the indent-on-continued-lines feature, but it was bad to start with.
This wraps up my changes to the autoformatter.
Contributor
Author
|
After some thought, I realised that there is a small bug in my new indent algorithm, so that I think it will produce the following: |
Contributor
Author
|
Sorry, that should have been |
Am commiting before attempting to fix by mass deletion of code.
This adds proper support for indents caused by continuing to a new line, allows arrays to be expressed in more compact form, prevents the final line being eaten if it isn't properly ended, and neatens code.
9a6160e to
eb8b08c
Compare
Contributor
|
Doing some cleanup here, so closing this one since it's WIP. Please re-submit when it's ready to go. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2540, #1041, and lack of EOF checking. Also tried to continue neatening and commenting code. I find it amusing that I am fixing a bug that should have been spotted before I was born (the EOF one).