Skip to content

chore: bump prettier and eslint-plugin-prettier#20181

Merged
Jolg42 merged 3 commits into
prisma:mainfrom
mrazauskas:chore-bump-prettier
Jul 12, 2023
Merged

chore: bump prettier and eslint-plugin-prettier#20181
Jolg42 merged 3 commits into
prisma:mainfrom
mrazauskas:chore-bump-prettier

Conversation

@mrazauskas
Copy link
Copy Markdown
Contributor

@mrazauskas mrazauskas commented Jul 12, 2023 •
edited
Loading

Closes #20082
Closes #20179

prettier and eslint-plugin-prettier should be updated together. Since this is major version of prettier, there are few changes in formatting.

@mrazauskas mrazauskas requested a review from a team as a code owner July 12, 2023 05:07
@mrazauskas mrazauskas requested review from Jolg42 and aqrln and removed request for a team July 12, 2023 05:07
mrazauskas
mrazauskas commented Jul 12, 2023
View reviewed changes
Comment thread .prettierrc.yml
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jul 12, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: prettier@2.8.8

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 12, 2023

CodSpeed Performance Report

Merging #20181 will degrade performances by 45.68%

Comparing mrazauskas:chore-bump-prettier (3be7ac0) with main (b0ad481)

Summary

❌ 1 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mrazauskas:chore-bump-prettier Change
❌ typescript compilation ~50 Models 87.5 ms 161.1 ms -45.68%

Jolg42
Jolg42 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrazauskas for the PR 💚

@Jolg42 Jolg42 added this to the 5.1.0 milestone Jul 12, 2023
@Jolg42 Jolg42 merged commit d9eb856 into prisma:main Jul 12, 2023
@mrazauskas mrazauskas deleted the chore-bump-prettier branch July 12, 2023 08:37
@mrazauskas
Copy link
Copy Markdown
Contributor Author

mrazauskas commented Jul 12, 2023 •
edited
Loading

@Jolg42 Sorry, I forgot one detail. Current, if Prettier v3 is installed, Jest fails to update inline snapshots. There are two solutions:

  • downgrade Prettier to v2
  • add prettierPath: null to Jest config. This will make sure Jest does not run Prettier, but new inline snapshots should be formatted outside Jest.

What would you prefer?

As you see in CI, all works with existing snaps. The problem accrues if they have to be updated or created.

Reference: jestjs/jest#14305

@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Jul 12, 2023

Ouch 😢

It sounds to me like reverting is easier/best until this is figured out then.

Jolg42 added a commit that referenced this pull request Jul 12, 2023
@Jolg42
Revert "chore: bump prettier and eslint-plugin-prettier (#20181)"
2240b12 
This reverts commit d9eb856.
@Jolg42 Jolg42 mentioned this pull request Jul 12, 2023
Merged
@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Jul 12, 2023

PR created from "Revert" UI button #20182

@mrazauskas
Copy link
Copy Markdown
Contributor Author

mrazauskas commented Jul 12, 2023

It sounds to me like reverting is easier/best until this is figured out then.

Agreed. I will come back after the issue is fixed on Jest side.

@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Jul 12, 2023

Thank you!

@Jolg42
Copy link
Copy Markdown
Contributor

Jolg42 commented Jul 27, 2023

Now Jest will error in next version
jestjs/jest#14367

Tracking issue to monitor
jestjs/jest#14305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aqrln aqrln Awaiting requested review from aqrln aqrln was automatically assigned from prisma/orm-ts-maintain

1 more reviewer

@Jolg42 Jolg42 Jolg42 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mrazauskas @Jolg42