fix(typescript): remove extra trailing comma in generic arrow functions#19011
Closed
ljjunh wants to merge 2 commits intoprettier:mainfrom
Closed
fix(typescript): remove extra trailing comma in generic arrow functions#19011ljjunh wants to merge 2 commits intoprettier:mainfrom
ljjunh wants to merge 2 commits intoprettier:mainfrom
Conversation
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18997
shouldForceTrailingCommainsrc/language-js/print/type-parameters.jswas using a negative check!(options.filepath && /\.ts$/.test(options.filepath)), which incorrectly added a trailing comma to genericarrow functions when no filepath was provided (e.g., via API or playground).
The trailing comma
<T,>is only needed in.tsx/.jsxfiles to prevent<T>from being misidentified as aJSX tag. Changed the condition to explicitly check for JSX-capable file extensions.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.