Skip to content

Fix duplicate dangling comments in experimental ternaries#18963

Merged
fisker merged 3 commits intoprettier:mainfrom
kovsu:fix-#18944
Apr 11, 2026
Merged

Fix duplicate dangling comments in experimental ternaries#18963
fisker merged 3 commits intoprettier:mainfrom
kovsu:fix-#18944

Conversation

@kovsu
Copy link
Copy Markdown
Contributor

@kovsu kovsu commented Mar 23, 2026

Description

Fix #18944

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 23, 2026

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/plugin-hermes@18963.tgz
yarn add https://pkg.pr.new/@prettier/plugin-oxc@18963.tgz
yarn add https://pkg.pr.new/prettier@18963.tgz

commit: 8f7e9c3

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 23, 2026

Deploy Preview for prettier ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f7e9c3
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/69c126a12f374f0008b5abd5
😎 Deploy Preview https://deploy-preview-18963--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker fisker requested a review from rattrayalex April 10, 2026 04:27
Copy link
Copy Markdown
Collaborator

@rattrayalex rattrayalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing this and sorry for the bug!

@fisker fisker merged commit 3031cd3 into prettier:main Apr 11, 2026
38 checks passed
@kovsu kovsu deleted the fix-#18944 branch April 12, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

experimentalTernaries duplicates comment in array

3 participants