Replacing deprecated "request" package with native https module#216
Merged
Conversation
Installing packages again without "request" package. New version of NPM are generating new updated version of package-lock.json file.
PrerenderServiceUrl is set 'https://service.prerender.io/' by default. But user can override it with process.env.PRERENDER_SERVICE_URL. In case that user override it with "http" url, "http" module will be used.
varrocs
reviewed
Nov 5, 2021
| @@ -1,37 +1,1836 @@ | |||
| { | |||
| "name": "prerender-node", | |||
| "version": "3.3.0", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 2, | |||
Contributor
There was a problem hiding this comment.
Please stay at lock file version 1 for now.
Use nvm use --lts before running npm install.
Contributor
Author
There was a problem hiding this comment.
I think it is not necessary since v2 is backward compatible with v1.
https://github.blog/2021-02-02-npm-7-is-now-generally-available/#changes-to-the-lockfile
varrocs
reviewed
Nov 5, 2021
varrocs
reviewed
Nov 5, 2021
varrocs
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
requestpackage is deprecated, CLI always throws warnings for it. I replaced it with nativehttpsmodule, so your package will not have any dependency anymore. I also changed deprecatedurl.parsewith recommended WHATWG URL API. I tested my changes and it works on my side, but you are welcome to test it also before considering to merge the PR.All the best,
Nenad