Skip to content

Fix UMD resolution for mixed inline and @babel/runtime Babel helpers#626

Open
Andarist wants to merge 7 commits into
mainfrom
fix/babel-helpers-bundling
Open

Fix UMD resolution for mixed inline and @babel/runtime Babel helpers#626
Andarist wants to merge 7 commits into
mainfrom
fix/babel-helpers-bundling

Conversation

@Andarist
Copy link
Copy Markdown
Member

@Andarist Andarist commented May 8, 2026

No description provided.

@Andarist Andarist requested a review from emmatown May 8, 2026 10:43
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: e1b85d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread .changeset/forty-deers-greet.md Outdated
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.96%. Comparing base (8a86cca) to head (e1b85d3).

Files with missing lines Patch % Lines
packages/cli/src/rollup-plugins/babel.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files          39       39           
  Lines        2118     2133   +15     
  Branches      652      656    +4     
=======================================
+ Hits         1969     1983   +14     
- Misses        138      139    +1     
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"@preconstruct/cli": patch
---

Fix UMD resolution for mixed inline and `@babel/runtime` Babel helpers
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the mixed part of this, isn't this just fixing the case of using @babel/runtime for UMD builds and the inline case already worked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants