Skip to content

[dependencies-replacement] Replace fs-extra with node:fs/promises#607

Open
VanTanev wants to merge 1 commit into
preconstruct:mainfrom
VanTanev:dependencies-replace-fs-extra
Open

[dependencies-replacement] Replace fs-extra with node:fs/promises#607
VanTanev wants to merge 1 commit into
preconstruct:mainfrom
VanTanev:dependencies-replace-fs-extra

Conversation

@VanTanev

@VanTanev VanTanev commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

References #608

Removes 5 dependencies

@changeset-bot

changeset-bot Bot commented Oct 13, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dc44f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VanTanev VanTanev force-pushed the dependencies-replace-fs-extra branch from 80694a1 to d2a8a82 Compare October 13, 2024 14:57
@codecov

codecov Bot commented Oct 13, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (54c412d) to head (dc44f54).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   92.48%   92.51%   +0.03%     
==========================================
  Files          39       39              
  Lines        2076     2085       +9     
  Branches      639      640       +1     
==========================================
+ Hits         1920     1929       +9     
  Misses        145      145              
  Partials       11       11              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VanTanev

Copy link
Copy Markdown
Contributor Author

I need some guidance if the changes being introduced by replacing dependencies should be considered a minor change or a major one.

It seems that previously, when fast-glob was introduced, it was treated as a major change.

@VanTanev VanTanev force-pushed the dependencies-replace-fs-extra branch 3 times, most recently from 3eab125 to dc44f54 Compare October 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant