This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Merged
Conversation
mafintosh
reviewed
Dec 6, 2016
| }) | ||
| } | ||
| ] | ||
| if (fs.existsSync(tarPath) && !opts.force) { |
Collaborator
There was a problem hiding this comment.
whats the benefit to using existsSync over stat here? function is async anyway
Member
Author
There was a problem hiding this comment.
Personally I think it only makes the code more readable.
But there are also discussions about why existsSync may be better/faster
EDIT: This is actually not the case, here's the link: nodejs/node#8364
Collaborator
There was a problem hiding this comment.
I don't think we should start using sync calls in async methods. It's a bad pattern.
Member
Author
There was a problem hiding this comment.
👍 Removed the last commit.
Collaborator
|
+1 except for the sync call |
Collaborator
|
👍 Thanks! Do you wanna help maintain this in general? |
Collaborator
|
5.0.1 |
Member
Author
Sure, I'm happy to help 🎉 |
| buildLog('Prebuild written to ' + tarPath) | ||
| callback(null, tarPath) | ||
| }) | ||
| async.waterfall(tasks, callback) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
fs.statwithfs.existsSyncnoop-login tests