Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SyntaxNode
left a comment
There was a problem hiding this comment.
Looks good. Left some minor comments. Did you want to include the "Rules that will be enforced later" section from prebid/prebid-server#2437?
We're also missing the recommendation of "Bid adapters should understand how their endpoints handle currency and floors and transform the PBS request appropriately.".
| 1. Bid adapters must be able to bid. If they cannot return an auction bid, they should consider integration as a Real-Time Data or other module type. | ||
| 1. Creative rendering scripts must(*) load from the creative frame and not directly in the page. In other words, creative rendering JavaScript cannot be used to bypass the “no external code” rule. | ||
| 1. Bidder modules must not(*) make requests to endpoints for functionality other than auctions without: | ||
| 1. Bidder modules must not make requests to endpoints for functionality other than auctions without: |
There was a problem hiding this comment.
Would this be PBJS specific? For server, issue prebid/prebid-server#2437 states "Bidder modules must not make requests to endpoints for functionality other than auctions." without exception.
There was a problem hiding this comment.
The rules committee allowed for the possibility of exceptions for JS -- I think that would apply to PBS as well
|
Thanks @SyntaxNode . It wasn't clear to me that "currency and floors" is an enforceable rule, but I suppose that several other of these things aren't really enforceable either, so added. |
* PBS rules update * review feedback * Update module-rules.md
Related to prebid/prebid-server#2437