Skip to content

GitHub: Add pull request checklist#3227

Merged
SerhiiNahornyi merged 2 commits into
masterfrom
add-pr-checklist
Jun 4, 2024
Merged

GitHub: Add pull request checklist#3227
SerhiiNahornyi merged 2 commits into
masterfrom
add-pr-checklist

Conversation

@And1sS
Copy link
Copy Markdown
Collaborator

@And1sS And1sS commented Jun 4, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Pull request reviews are time consuming.

🧠 Rationale behind the change

We would like to ease pull request review process, thus we decided to introduce pull request checklist.

🧪 Test plan

No test plan needed.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@And1sS And1sS changed the title add-pr-checklist GitHub: Add pull request checklist Jun 4, 2024
Copy link
Copy Markdown
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants