Skip to content

feat: optimise jsx runtime #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 5 commits into from
Apr 17, 2024
Merged

feat: optimise jsx runtime #4337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8524bb8
optimise jsx-runtime by only creating a new object when ref is passed
JoviDeCroock Apr 11, 2024
8a060b9
add test
JoviDeCroock Apr 11, 2024
4f085f1
shave
JoviDeCroock Apr 11, 2024
d985225
Update jsx-runtime/src/index.js
JoviDeCroock Apr 17, 2024
7cf88e5
fix
JoviDeCroock Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions jsx-runtime/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,22 @@ const isArray = Array.isArray;
* @param {unknown} [__self]
*/
function createVNode(type, props, key, isStaticChildren, __source, __self) {
if (!props) props = {};
// We'll want to preserve `ref` in props to get rid of the need for
// forwardRef components in the future, but that should happen via
// a separate PR.
let normalizedProps = {},
let normalizedProps = props,
ref,
i;
for (i in props) {
if (i == 'ref') {
ref = props[i];
} else {
normalizedProps[i] = props[i];

if ('ref' in normalizedProps) {
normalizedProps = {};
for (i in props) {
if (i == 'ref') {
ref = props[i];
} else {
normalizedProps[i] = props[i];
}
}
}

Expand Down
10 changes: 9 additions & 1 deletion jsx-runtime/test/browser/jsx-runtime.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,16 @@ describe('Babel jsx/jsxDEV', () => {

it('should keep ref in props', () => {
const ref = () => null;
const vnode = jsx('div', { ref });
const props = { ref };
const vnode = jsx('div', props);
expect(vnode.ref).to.equal(ref);
expect(vnode.props).to.not.equal(props);
});

it('should not copy props wen there is no ref in props', () => {
const props = { x: 'y' };
const vnode = jsx('div', props);
expect(vnode.props).to.equal(props);
});

it('should add keys', () => {
Expand Down