Skip to content

Handle config paths on different Windows drives #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikemikimike wants to merge 3 commits into from
+15 −1
Closed

Handle config paths on different Windows drives #3750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93871f8
Handle config paths on different drives
mikemikimike Aug 29, 2026
73b562d
Revert "Handle config paths on different drives"
mikemikimike Aug 29, 2026
1802c5c
Handle config paths on different drives
mikemikimike Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pre_commit/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,12 @@ def _adjust_args_and_chdir(args: argparse.Namespace) -> None:
toplevel = git.get_root()
os.chdir(toplevel)

args.config = os.path.relpath(args.config)
try:
args.config = os.path.relpath(args.config)
except ValueError:
# A config file on a different drive cannot be made relative to the
# repository. Keep the absolute path so it remains usable.
pass
if args.command in {'run', 'try-repo'}:
args.files = [os.path.relpath(filename) for filename in args.files]
if args.commit_msg_filename is not None:
Expand Down
9 changes: 9 additions & 0 deletions tests/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ def test_adjust_args_and_chdir_non_relative_config(in_git_dir):
assert args.config == C.CONFIG_FILE


def test_adjust_args_and_chdir_config_on_different_drive(in_git_dir):
args = _args(config=r'C:\config\.pre-commit-config.yaml')

with mock.patch.object(main.os.path, 'relpath', side_effect=ValueError):
main._adjust_args_and_chdir(args)

assert args.config == r'C:\config\.pre-commit-config.yaml'


def test_adjust_args_try_repo_repo_relative(in_git_dir):
with in_git_dir.join('foo').ensure_dir().as_cwd():
args = _args(command='try-repo', repo='../foo', files=[])
Expand Down
Loading