Skip to content

make --hook-dir optional for hook-impl#3662

Merged
asottile merged 1 commit into
mainfrom
hook-impl-optional-hook-dir
Apr 21, 2026
Merged

make --hook-dir optional for hook-impl#3662
asottile merged 1 commit into
mainfrom
hook-impl-optional-hook-dir

Conversation

@asottile
Copy link
Copy Markdown
Member

for git 2.54+ hooks it does not make sense to run legacy hooks (they will be run anyway at the original path and/or multiple commands can be configured for a single hook)

in that case we skip running them via hook-impl by not passing --hook-dir at all

@asottile asottile enabled auto-merge April 21, 2026 19:49
@asottile asottile merged commit 2a51ffc into main Apr 21, 2026
11 checks passed
@asottile asottile deleted the hook-impl-optional-hook-dir branch April 21, 2026 19:56
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 8, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [pre-commit](https://github.com/pre-commit/pre-commit) | minor | `4.5.1` → `4.6.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21)

[Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0)

\==================

##### Features

- `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier
  usage with `git` 2.54+ git hooks.
  - [#&#8203;3662](pre-commit/pre-commit#3662) MR by [@&#8203;asottile](https://github.com/asottile).

##### Fixes

- `pre-commit hook-impl`: `--hook-type` is required.
  - [#&#8203;3661](pre-commit/pre-commit#3661) MR by [@&#8203;asottile](https://github.com/asottile).

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNjguNSIsInVwZGF0ZWRJblZlciI6IjQzLjE2OC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant