Skip to content

use git cat-file -e instead of git rev-list in _rev_exists #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptarjan wants to merge 11 commits into
base: main
Choose a base branch
from
+4 −1
Open

use git cat-file -e instead of git rev-list in _rev_exists #3605

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b285ccc
use git cat-file -e instead of git rev-list in _rev_exists
ptarjan Dec 26, 2025
5a4235c
remove == 0
ptarjan Dec 26, 2025
a26fb3b
Revert "remove == 0"
ptarjan Dec 26, 2025
ed0d44b
redirect stderr to devnull
ptarjan Dec 26, 2025
7b1d351
line length
ptarjan Dec 26, 2025
ade6b69
convert to not not
ptarjan Dec 26, 2025
2b39c90
maybe parens?
ptarjan Dec 26, 2025
07ad091
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 26, 2025
aec2057
use bool
ptarjan Dec 26, 2025
58cbea1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 26, 2025
3203dd3
remove bool
ptarjan Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use bool
  • Loading branch information
@ptarjan
ptarjan committed Dec 26, 2025
commit aec205773a27a4b3227e5a581408dd46a3112cdc
10 changes: 4 additions & 6 deletions pre_commit/commands/hook_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,10 @@ def _ns(


def _rev_exists(rev: str) -> bool:
return not (
not subprocess.call(
('git', 'cat-file', '-e', rev),
stderr=subprocess.DEVNULL,
)
)
return not bool(subprocess.call(
('git', 'cat-file', '-e', rev),
stderr=subprocess.DEVNULL,
))


def _pre_push_ns(
Expand Down
Loading