Skip to content

improve julia language support #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericphanson wants to merge 8 commits into from
Closed

improve julia language support #3494

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7f8efa
improve julia support
ericphanson Jul 21, 2025
9583b19
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 21, 2025
0c54b47
make flake and mypy happier
ericphanson Jul 21, 2025
5501721
add
ericphanson Jul 21, 2025
ae6f19d
add test for julia version support
ericphanson Jul 21, 2025
f2837cf
add channel
ericphanson Jul 21, 2025
9a04b39
copy rust's pattern for conditional env
ericphanson Jul 21, 2025
1ba5581
restore comment
ericphanson Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
copy rust's pattern for conditional env
  • Loading branch information
@ericphanson
ericphanson committed Jul 21, 2025
commit 9a04b3967a8f6963cf3146e4b39dcf51b2ce2026
19 changes: 8 additions & 11 deletions pre_commit/languages/julia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@
import shutil
from collections.abc import Generator
from collections.abc import Sequence
from typing import Union

from pre_commit import lang_base
from pre_commit.envcontext import _Unset
from pre_commit.envcontext import envcontext
from pre_commit.envcontext import PatchesT
from pre_commit.envcontext import UNSET
from pre_commit.envcontext import Var
from pre_commit.prefix import Prefix
from pre_commit.util import cmd_output_b

Expand Down Expand Up @@ -49,17 +46,17 @@ def run_hook(
)


PatchEntry = tuple[str, Union[str, _Unset, tuple[Union[str, Var], ...]]]


def get_env_patch(target_dir: str, version: str) -> PatchesT:
patches: list[PatchEntry] = [
patches = (
('JULIA_LOAD_PATH', target_dir),
('JULIA_PROJECT', UNSET),
]
if version not in ('system', 'default'):
patches.append(('JULIAUP_CHANNEL', version))
return tuple(patches)
# Only set JULIAUP_CHANNEL if we don't want use the system's default
*(
(('JULIAUP_CHANNEL', version),)
if version not in ('system', 'default') else ()
),
)
return patches


@contextlib.contextmanager
Expand Down