Repository navigation
Implement post-commit - #1415
Merged
Merged
Conversation
Contributor
Author
|
Oh, I also added *.idea to the gitignore to prevent intellij from adding stuff that's irrelevant, feel free to remove it if it's unwanted. |
Member
just a general tip for open source, you should never touch |
asottile
reviewed
Apr 26, 2020
ModischFabrications
marked this pull request as ready for review
April 26, 2020 20:28
Contributor
Author
|
Ready for review, should be mergeable. |
asottile
reviewed
Apr 27, 2020
asottile
reviewed
Apr 27, 2020
asottile
reviewed
Apr 27, 2020
Contributor
Author
|
alright, any last objections? I think it's done. |
asottile
reviewed
Apr 27, 2020
Member
|
also, please stop saying "it's ready to merge" or "it's done" -- it sounds very pretentious and you don't decide when it's done, the project does |
asottile
reviewed
Apr 27, 2020
Member
|
thanks again, this has been released as part of v2.4.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement post-commit as an additional git hook.
This will close #1411.