resolving/git-resolver/test/index.ts (1)

376-392: ⚡ Quick win

Cover both GitLab specifier forms in this regression test.

This test currently exercises only the HTTPS GitLab specifier. Since the bug report includes both https://gitlab.com/... and gitlab:..., adding the shorthand form here would close a small coverage gap and guard parser-specific regressions.

Suggested test refinement

-test('resolveFromGit() gitlab tarball uses /-/archive/ URL without encoded slash', async () => {
+test.each([
+  'https://gitlab.com/pnpmjs/git-resolver',
+  'gitlab:pnpmjs/git-resolver',
+])('resolveFromGit() gitlab tarball uses /-/archive/ URL without encoded slash (%s)', async (bareSpecifier) => {
   const headCommit = '988c61e11dc8d9ca0b5580cb15291951812549dc'
   jest.mocked(fetchWithDispatcher).mockImplementation(async (_url, _opts) => {
     return { ok: true } as any // eslint-disable-line `@typescript-eslint/no-explicit-any`
   })
   jest.mocked(git).mockImplementation(async () => ({ stdout: `${headCommit}\tHEAD` }))
-  const resolveResult = await resolveFromGit({ bareSpecifier: 'https://gitlab.com/pnpmjs/git-resolver' })
+  const resolveResult = await resolveFromGit({ bareSpecifier })
   expect(resolveResult).toStrictEqual({
     id: `https://gitlab.com/pnpmjs/git-resolver/-/archive/${headCommit}/git-resolver-${headCommit}.tar.gz`,
     normalizedBareSpecifier: 'gitlab:pnpmjs/git-resolver',
     resolution: {
       tarball: `https://gitlab.com/pnpmjs/git-resolver/-/archive/${headCommit}/git-resolver-${headCommit}.tar.gz`,
       gitHosted: true,
     },
     resolvedVia: 'git-repository',
   })
 })

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@resolving/git-resolver/test/index.ts` around lines 376 - 392, Add coverage
for the GitLab shorthand form by duplicating or parameterizing the existing test
for resolveFromGit() (test name: "resolveFromGit() gitlab tarball uses
/-/archive/ URL without encoded slash") to also call resolveFromGit with
bareSpecifier: 'gitlab:pnpmjs/git-resolver'; keep the same mocked git (git ->
stdout `${headCommit}\tHEAD`) and fetchWithDispatcher mock, and assert the
expected result object uses id and resolution.tarball
`https://gitlab.com/pnpmjs/git-resolver/-/archive/${headCommit}/git-resolver-${headCommit}.tar.gz`
and normalizedBareSpecifier 'gitlab:pnpmjs/git-resolver' so both the HTTPS and
shorthand forms are validated.