Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes the linking of commands for engine runtimes (node, deno, bun) when package manifests are missing, addressing issue #10244.
Key Changes:
- Refactored bin linking logic to handle null manifests by extracting
getBinsForKnownRuntimesfunction - Updated
linkBinsOfPackagesto acceptDependencyManifest | nulland conditionally use runtime detection - Removed default empty object fallback (
?? {}) in build-modules to allow null manifests to flow through
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg-manager/link-bins/src/index.ts | Updates linkBinsOfPackages to accept null manifests, extracts getBinsForKnownRuntimes function for handling engine runtime directories without package.json files |
| exec/build-modules/src/index.ts | Removes the ?? {} fallback to allow null manifests, enabling runtime detection for packages without manifest files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
close #10244
The runtime dependencies (node, bun, deno) don't ship with
package.jsonfiles. We have a workaround for them in link-bins to be able to find where their binaries are at. However, seems like it works inconsistently. So, we are now creating package.json files for them with the necessary info (their command locations).