Repository navigation
[jsp] Fix #5092: allow JSP directives and scriptlets before the doctype - #7252
Open
InnoxCodes wants to merge 1 commit into
Open
InnoxCodes wants to merge 1 commit into
InnoxCodes wants to merge 1 commit into
Conversation
…ctype
The prolog of a JSP only accepted comments in front of the doctype
declaration, so the very common
<%@ page contentType="text/html" %>
<!DOCTYPE html>
failed with `Encountered "<!DOCTYPE"`. JSP directives, scriptlets,
declarations and comments are now accepted before the doctype.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Prolog()in Jsp.jjt only allowed comments before the doctype, so a page starting with a directive like<%@ page contentType="text/html" %>failed withEncountered "<!DOCTYPE". It now also accepts directives, scriptlets and declarations there.New test
testDoctypeAfterJspDirectivesin JspDocStyleTest fails on main and passes now. I ran all the pmd-jsp tests (150) and checkstyle for the module, not the whole./mvnw clean verify. The issue has no file attached, so this matches the message but I can't be sure it's the reporter's exact case.Related issues
<!DOCTYPE html>#5092Ready?
./mvnw clean verifypasses (checked automatically by github actions)