FF requires numpy#667
Merged
Merged
Conversation
Contributor
Author
|
@chriddyp for review. Seem ok? //cc @choldgraf 😸 just some setup towards a faster figure factory methods. |
Merged
Contributor
Author
|
^^ huh, rebuilt, seems like an intermittent npm fail? |
Contributor
|
sweet! thx for keeping me in the loop |
beab1d3 to
6e869cc
Compare
Note that we don’t necessarily *require* `numpy` for in all the FF methods. We’re just looking to make the compatibility-breaking change so that we can depend on it in `2.0.0`. Also note that I’d forgotten to include `figure_factory` in setup.py before ;__;.
6e869cc to
7e3b358
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that we don’t necessarily require
numpyfor in all the FFmethods. We’re just looking to make the compatibility-breaking
change so that we can depend on it in
2.0.0.Also note that I’d forgotten to include
figure_factoryin setup.pybefore ;__;.