Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup and consolidate
  • Loading branch information
emilykl committed Apr 7, 2026
commit 3f47babee5ee863e0ce8316ed6631c3c708da2ad
27 changes: 27 additions & 0 deletions .github/actions/setup-chrome-for-pytest/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Set up Chrome for pytest
description: Install Chrome/Chromedriver, set BROWSER, and verify the setup
runs:
using: composite
steps:
- name: Set up Chrome
id: setup-chrome
uses: browser-actions/setup-chrome@v2.1.1
with:
install-chromedriver: true
- name: Set BROWSER env var
shell: bash
run: |
echo "BROWSER=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV
- name: Check Chrome setup
shell: bash
run: |
CHROME_PATH="${{ steps.setup-chrome.outputs.chrome-path }}"
CHROMEDRIVER_PATH="${{ steps.setup-chrome.outputs.chromedriver-path }}"
echo "Chrome path: $CHROME_PATH"
echo "Chrome version: $($CHROME_PATH --version)"
echo "Chromedriver path: $CHROMEDRIVER_PATH"
echo "Chromedriver version: $($CHROMEDRIVER_PATH --version)"
echo "chrome --version: $(chrome --version)"
echo "BROWSER = $BROWSER"
python -c "import webbrowser; webbrowser.register_standard_browsers(); print(webbrowser._tryorder)"
python -c "import webbrowser; webbrowser.get()"
69 changes: 5 additions & 64 deletions .github/workflows/run-pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ jobs:
source .venv/bin/activate
uv lock --check
uv sync --extra dev_core
- name: List installed packages and python version
run: |
source .venv/bin/activate
uv pip list
python --version
- name: Test core
run: |
Expand All @@ -49,44 +45,19 @@ jobs:
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
- name: Set up Chrome
id: setup-chrome
uses: browser-actions/setup-chrome@v2.1.1
with:
install-chromedriver: true
- name: Print installed Chrome and Chromedriver paths and versions
run: |
CHROME_PATH="${{ steps.setup-chrome.outputs.chrome-path }}"
CHROMEDRIVER_PATH="${{ steps.setup-chrome.outputs.chromedriver-path }}"
echo "Chrome path: $CHROME_PATH"
echo "Chrome version: $($CHROME_PATH --version)"
echo "Chromedriver path: $CHROMEDRIVER_PATH"
echo "Chromedriver version: $($CHROMEDRIVER_PATH --version)"
echo "chrome --version: $(chrome --version)"
- name: Set BROWSER env var
run: |
echo "BROWSER=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV
- name: Print Python webbrowser standard browser list
run: |
python -c "import webbrowser; webbrowser.register_standard_browsers(); print(webbrowser._tryorder)"
- name: Check whether we can access Chrome from Python
run: |
python -c "import webbrowser; webbrowser.get()"
- name: Set up Chrome for Pytest
uses: ./.github/actions/setup-chrome-for-pytest
- name: Install dependencies
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
uv venv
source .venv/bin/activate
uv sync --extra dev_optional
python --version
- name: Test core
run: |
source .venv/bin/activate
python -m pytest tests/test_core
- name: List installed packages and python version
run: |
source .venv/bin/activate
uv pip list
python --version
- name: Test optional
run: |
source .venv/bin/activate
Expand Down Expand Up @@ -117,29 +88,8 @@ jobs:
uses: actions/setup-python@v6
with:
python-version: "3.9"
- name: Set up Chrome
id: setup-chrome
uses: browser-actions/setup-chrome@v2.1.1
with:
install-chromedriver: true
- name: Print installed Chrome and Chromedriver paths and versions
run: |
CHROME_PATH="${{ steps.setup-chrome.outputs.chrome-path }}"
CHROMEDRIVER_PATH="${{ steps.setup-chrome.outputs.chromedriver-path }}"
echo "Chrome path: $CHROME_PATH"
echo "Chrome version: $($CHROME_PATH --version)"
echo "Chromedriver path: $CHROMEDRIVER_PATH"
echo "Chromedriver version: $($CHROMEDRIVER_PATH --version)"
echo "chrome --version: $(chrome --version)"
- name: Set BROWSER env var
run: |
echo "BROWSER=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV
- name: Print Python webbrowser standard browser list
run: |
python -c "import webbrowser; webbrowser.register_standard_browsers(); print(webbrowser._tryorder)"
- name: Check whether we can access Chrome from Python
run: |
python -c "import webbrowser; webbrowser.get()"
- name: Set up Chrome for browser tests
uses: ./.github/actions/setup-chrome-for-pytest
- name: Install dependencies
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
Expand All @@ -151,11 +101,6 @@ jobs:
run: |
source .venv/bin/activate
python -m pytest tests/test_core
- name: List installed packages and python version
run: |
source .venv/bin/activate
uv pip list
python --version
- name: Test optional
run: |
source .venv/bin/activate
Expand Down Expand Up @@ -198,10 +143,6 @@ jobs:
uv sync --extra dev_optional
uv pip uninstall kaleido
uv pip install kaleido==0.2.1
- name: List installed packages and python version
run: |
source .venv/bin/activate
uv pip list
python --version
- name: Test plotly.io image output with Kaleido v0
run: |
Expand Down