Skip to content

Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 3 commits into from
Apr 14, 2026
+2 −2
Merged

Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility #5522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce04f5e
Use `np.isin` instead of `np.in1d` to fix numpy 2.4 test compatibility
thunze Feb 23, 2026
21f4f2b
Merge branch 'main' into numpy-2.4-is1d-removal
emilykl Apr 14, 2026
d46fdb4
Merge branch 'main' into numpy-2.4-is1d-removal
emilykl Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility 
https://numpy.org/devdocs/release/2.4.0-notes.html#removed-numpy-in1d
  • Loading branch information
@thunze
thunze committed Feb 23, 2026
commit ce04f5e079a7a6b831ea1eec7ea240333e77a0d4
2 changes: 1 addition & 1 deletion tests/test_optional/test_px/test_px.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_custom_data_scatter(backend):
)
for data in fig.data:
assert np.all(
np.in1d(data.customdata[:, 1], iris.get_column("petal_width").to_numpy())
np.isin(data.customdata[:, 1], iris.get_column("petal_width").to_numpy())
)
# Hover and custom data, no repeated arguments
fig = px.scatter(
Expand Down
2 changes: 1 addition & 1 deletion tests/test_optional/test_px/test_px_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def test_sunburst_treemap_with_path_color(constructor):
fig = px.sunburst(
df.to_native(), path=path, color="sectors", color_discrete_map=cmap
)
assert np.all(np.in1d(fig.data[0].marker.colors, list(cmap.values())))
assert np.all(np.isin(fig.data[0].marker.colors, list(cmap.values())))

# Numerical column in path
df = (
Expand Down