Skip to content

Expose plotly.io.get_chrome() #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 3 commits into from
Jul 16, 2025
Merged

Expose plotly.io.get_chrome() #5282

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d6246b
expose plotly.io.get_chrome()
emilykl Jul 16, 2025
f667bc4
add test to make sure plotly.io.get_chrome() is exposed
emilykl Jul 16, 2025
a0baca3
fix test
emilykl Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@emilykl
emilykl committed Jul 16, 2025
commit a0baca39b5788b8a15115b6323e1ef9acbce941c
37 changes: 16 additions & 21 deletions tests/test_optional/test_kaleido/test_kaleido.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,24 +298,19 @@ def test_fig_to_image():
def test_get_chrome():
"""Test that plotly.io.get_chrome() can be called."""

with patch(
"plotly.io._kaleido.kaleido.get_chrome_sync",
return_value="/mock/path/to/chrome",
) as mock_get_chrome:
with patch("builtins.input", return_value="y"): # Mock user confirmation
with patch(
"sys.argv", ["plotly_get_chrome", "-y"]
): # Mock CLI args to skip confirmation
if not kaleido_available() or kaleido_major() < 1:
# Test that ValueError is raised when Kaleido requirements aren't met
with pytest.raises(
ValueError,
match="This command requires Kaleido v1.0.0 or greater",
):
pio.get_chrome()
else:
# Test normal operation when Kaleido v1+ is available
pio.get_chrome()

# Verify that kaleido.get_chrome_sync was called
mock_get_chrome.assert_called_once()
if not kaleido_available() or kaleido_major() < 1:
# Test that ValueError is raised when Kaleido requirements aren't met
with pytest.raises(
ValueError, match="This command requires Kaleido v1.0.0 or greater"
):
pio.get_chrome()
else:
# Test normal operation when Kaleido v1+ is available
with patch(
"plotly.io._kaleido.kaleido.get_chrome_sync",
return_value="/mock/path/to/chrome",
) as mock_get_chrome:
pio.get_chrome()

# Verify that kaleido.get_chrome_sync was called
mock_get_chrome.assert_called_once()