Python version fixes - #145
Conversation
1. Plotly uses 2.7 on the backend so it will return bytes! The json 3.x module expects native string (unicode), so we need to convert this. 2. base64encode requires bytes, so give it bytes and convert after.
This test was actually dependent on what order or what subset of the tests you were running!
|
wow, thx for doing this! very informative. i wonder what our test coverage is.. and if there is some other uncovered stuff. did you just test these locally? |
|
things like 'print' statements are easy to search for (as well as the '{}') patterns. but the encoding stuff can be a little sneaky. as for test coverage, you can find them in the artifacts of the circle builds, it's actually pretty decent yeah, i just tested these locally, i have a little vagrant setup to pop open a box, install all our deps for a number of python versions and then a command to run some tests. I'm sure it's pretty janky, but it does the job for now. soon i'll get it properly into circle though. |
|
cool to merge? |
|
💃 On Fri, Nov 14, 2014 at 7:54 PM, Andrew notifications@github.com wrote:
Chris Parmer |
huzzah, python 2.6, 2.7, 3.3, and 3.4 tests are run and are passing again!