fix(sankey): transpose node.x/node.y scaling for vertical orientation (Fixes #7947) - #7957
Open
waterWang wants to merge 1 commit into
Open
fix(sankey): transpose node.x/node.y scaling for vertical orientation (Fixes #7947)#7957waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For vertical Sankey traces (orientation: 'v'), user-supplied
node.x/node.yare normalized against the wrong extent. The d3-sankey layout space always carries the flow along itsxaxis, but for vertical orientation that space is transposed onto the screen. When the plotting area is non-square, nodes are placed outside the bounding box and the values written back after a drag can exceed the documented[0, 1]range.Root cause
In
src/traces/sankey/render.js,sankeyModel():The user coordinates at (2) are scaled by the un-transposed extents, while the d3-sankey layout at (1) uses the transposed extents. The same asymmetry exists in the write-back path
persistFinalNodePositions().Fix
sankeyModel(): scalenode.xby the flow-axis extent andnode.yby the cross-axis extent, matching thesankey.size()transpositionpersistFinalNodePositions(): divide by the same transposed extents on write-backCloses #7947