fix(geo): preserve D3 projection default rotation when user does not set rotation - #7956
Open
waterWang wants to merge 1 commit into
Open
fix(geo): preserve D3 projection default rotation when user does not set rotation#7956waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…set rotation Geo.updateProjection unconditionally called projection.rotate() which overwrites the D3 projection's built-in default rotation. For projections that ship with a non-identity default (e.g. peirce quincuncial [-90,-90,45], wiechel [0,-90,45]), the map rendered in a different orientation. Only call projection.rotate() when the user explicitly set rotation values or when fitbounds has derived a rotation from the data. Otherwise preserve the D3 projection's default rotation so maps render in their canonical orientation. Fixes plotly#7949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7949
Problem
Geo.updateProjection unconditionally calls projection.rotate() which overwrites the D3 projection's built-in default rotation. Six projections in plotly.js carry a non-identity default rotation (e.g. peirce quincuncial [-90, -90, 45], wiechel [0, -90, 45]), and the unconditional override causes these to render in the wrong orientation.
Fix
Only call projection.rotate() when the user explicitly set rotation values in the layout input, or when fitbounds has derived a rotation from the data. Otherwise preserve the D3 projection's default rotation so that maps render in their canonical orientation.
Testing