-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Clickable Legend Titles #7698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Clickable Legend Titles #7698
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
88a6c0d
Fix bug where `groupclick`: `toggleitem` doesn't work when there are …
alexshoe b2ef711
Add `titleclick` and `titledoubleclick` attributes
alexshoe cdb570a
Add handleTitleClick function for toggling visibility via legend title
alexshoe 089fa73
Add legend title click toggle setup and event handling
alexshoe 207910e
Add mock chart for legend title click feature
alexshoe 2f934ad
Only enable legend title click by default when there are multiple leg…
alexshoe cd92fea
Add jasmine tests for legend title click
alexshoe 53073d7
Update schema
alexshoe 7c2e878
Merge remote-tracking branch 'origin/master' into clickable-legend-ti…
alexshoe 459e229
Add baseline image
alexshoe 6bec6d1
Convert var to const where applicable
alexshoe fdf1d65
Move `getId()` to `helpers.js`
alexshoe 0cde808
Refactor handleClick() signature to be consistent with handleTitleClick
alexshoe 3a1336f
Add docstrings for `handleClick` and `handleTitleClick`
alexshoe 42c40f6
Replace null value with early continue and skip non-displayed traces
alexshoe 2b5d2af
Rename `handleClick` to `handleItemClick`
alexshoe 6cbdb49
Test legend title click attributes with non-default values
alexshoe 6f6fd91
Move titleToggle positioning into computeLegendDimensions
alexshoe e3a068e
Fix group title click resolving to wrong legend by adding missing leg…
alexshoe 28990fb
Update schema
alexshoe a9809d2
Update src/components/legend/attributes.js
alexshoe 1fc81de
Update src/components/legend/attributes.js
alexshoe fb5b11f
Merge remote-tracking branch 'origin/master' into clickable-legend-ti…
alexshoe f820e7f
Modify baseline images and update schema
alexshoe 8ee735e
Merge remote-tracking branch 'origin/master' into clickable-legend-ti…
alexshoe e0be8c5
Explicitly initialize toggleOtherLegends to false in toggle mode
alexshoe 0223993
Fix legend title opacity incorrectly dimming for pie traces with per-…
alexshoe e7a1915
Fix pie legend item clicks breaking due to array legend lookup crash
alexshoe dca2e38
Fix legend traces not toggling when chart is editable by passing lege…
alexshoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix legend title opacity incorrectly dimming for pie traces with per-…
…slice legend assignments
- Loading branch information
commit 02239934c6b65d4e737034bd8027131780e5ed96
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
alexshoe marked this conversation as resolved.
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.