Skip to content

Set default layout.axis.tickmode to 'sync' when axis is overlaying #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilykl wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Set default layout.axis.tickmode to 'sync' when axis is overlaying #7684

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
46a77cc
run formatter
emilykl Jan 6, 2026
eff3ec3
set default tickmode to 'sync' when axis is overlaying
emilykl Jan 6, 2026
fe1d62c
remove duplicate draw call for axes with tickmode: 'sync'
emilykl Jan 8, 2026
badfa8b
bugfix: if overlaid axis is categorical, default to 'auto' rather tha…
emilykl Jan 19, 2026
4d888f3
explicitly set tickmode auto for mock
emilykl Jan 19, 2026
a9b937b
update image baselines
emilykl Jan 7, 2026
7de68e8
update tickmode attribute description
emilykl Jan 20, 2026
7d71516
update plot-schema
emilykl Jan 20, 2026
79bf862
Apply suggestions from code review
emilykl Jan 26, 2026
528f6de
update plot-schema
emilykl Jan 26, 2026
72f92a2
add draftlog
emilykl Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
  • Loading branch information
@emilykl @camdecoster
emilykl and camdecoster committed Jan 26, 2026
commit 79bf8620b8ae7f92d8aaeb98e90e6382abde4ea3
2 changes: 1 addition & 1 deletion src/plots/cartesian/dragbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
var axListI = axList[i];
var axListIType = axListI[axisType];
var axId = axListIType._id;
if(!axListI.fixedrange && axListIType.tickmode === 'sync' && activeAxIds.indexOf(axId) === -1) {
if(!axListI.fixedrange && axListIType.tickmode === 'sync' && !activeAxIds.includes(axId)) {
activeAxIds.push(axId);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/plots/cartesian/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var tickmode = extendFlat({}, minorTickmode, {
minorTickmode.description,
'If *sync*, the number of ticks will sync with the overlayed axis',
'set by `overlaying` property. When no other tick info is provided,',
'overlyaing (non-categorical) axes default to *sync*, while other axes default to *auto*.',
'overlaying (non-categorical) axes default to *sync*, while other axes default to *auto*.',
].join(' ')
});

Expand Down
3 changes: 1 addition & 2 deletions src/plots/cartesian/tick_value_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray;
var isTypedArraySpec = require('../../lib/array').isTypedArraySpec;
var decodeTypedArraySpec = require('../../lib/array').decodeTypedArraySpec;

module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts) {
if (!opts) opts = {};
module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts = {}) {
var isMinor = opts.isMinor;
var cIn = isMinor ? containerIn.minor || {} : containerIn;
var cOut = isMinor ? containerOut.minor : containerOut;
Expand Down
Loading